-
Notifications
You must be signed in to change notification settings - Fork 118
Improve CI configuration #3553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI configuration #3553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @o-200, thank you for this contribution. Your #3551 issue addresses CI improvements we've very recently been discussing.
Along with this brakeman fix, triggering the Postgresql GH Action on pushes would also be very valuable. Would you like to include that CI improvement in this current PR? Or maybe you'd prefer it as a separate PR?
Done, but what about 'Tests - MySQL' action? I'd prefer enabling it if the project uses two databases, but now it's action was disabled. |
Good question. It sounds like we will remove the MySQL support in the near future. (Just added a bit more about in the issue you created: #3551) |
|
Thank you again for your work here @o-200. I had mentioned that these CI improvements were recently discussed. These discussions are related to a newly proposed release flow. Sorry to complicate things with your contribution here. You have done a perfect job following our contributors guide, but the guide will have to be updated to reflect the new release flow. (I have described some of the needed updates here: #3554) @andreadavanzo what would you propose here? I have just published the branch |
|
hey, @aaronskiba, i see that CI "Danger / danger (pull_request)" is crushing. It is a expected behavior? |
Yes, that is unfortuately a behaviour we've noticed with PRs from outside of the main repo. Sorry about that. |
|
Hi @o-200, sorry for the huge delay with this one. Given our newer release flow, rather than trying to merge PR, I went ahead and cherry-picked your changes and added them to our newest release. I hope that's alright. Thank you very much for your contribution here, these are some very nice improvements. |

Changes proposed in this PR:
This pull request is the part of #3551